chore: fix 0 kwei bug (#7387)

whitemoshui · web-flow · commit 5eeb2d618846 · 2024-11-19T10:50:33.000+01:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2809,3 +2809,7 @@ If there are any bugs, improvements, optimizations or any new feature proposal f
 #### web3
 
 -   Export Web3Account, Wallet and signature related types. (#7374)
+
+#### web3-utils
+
+-   Make `fromWei` return "0" when input is `0` (#7387)
diff --git a/packages/web3-utils/CHANGELOG.md b/packages/web3-utils/CHANGELOG.md
@@ -241,3 +241,7 @@ Documentation:
 -   fix `padRight` validation failure on large `uint` (#7265)
 
 ## [Unreleased]
+
+### Fixed
+
+-   Make `fromWei` return "0" when input is `0` (#7387)
diff --git a/packages/web3-utils/src/converters.ts b/packages/web3-utils/src/converters.ts
@@ -546,7 +546,7 @@ export const fromWei = (number: Numbers, unit: EtherUnits | number): string => {
 	const fraction = zeroPaddedValue.slice(-numberOfZerosInDenomination).replace(/\.?0+$/, '');
 
 	if (integer === '') {
-		return `0.${fraction}`;
+		return fraction ? `0.${fraction}` : '0';
 	}
 
 	if (fraction === '') {
diff --git a/packages/web3-utils/test/fixtures/converters.ts b/packages/web3-utils/test/fixtures/converters.ts
@@ -328,6 +328,9 @@ export const fromWeiValidData: [[Numbers, EtherUnits | number], Numbers][] = [
 	[['1123', 'kwei'], '1.123'],
 	[['1234100', 'kwei'], '1234.1'],
 	[['3308685546611893', 'ether'], '0.003308685546611893'],
+	[['0', 'wei'], '0'],
+	[['0', 'kwei'], '0'],
+	[['0', 'ether'], '0'],
 ];
 
 export const toWeiValidData: [[Numbers, EtherUnits | number], Numbers][] = [

Original file line number	Diff line number	Diff line change
`@@ -546,7 +546,7 @@ export const fromWei = (number: Numbers, unit: EtherUnits \| number): string => {`
`546`	`546`	`const fraction = zeroPaddedValue.slice(-numberOfZerosInDenomination).replace(/\.?0+$/, '');`
`547`	`547`
`548`	`548`	`if (integer === '') {`
`549`		- return `0.${fraction}`;
	`549`	+ return fraction ? `0.${fraction}` : '0';
`550`	`550`	`}`
`551`	`551`
`552`	`552`	`if (fraction === '') {`