Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Fix 7055 one of with scalar value and string #7173

Merged
merged 7 commits into from
Aug 8, 2024
Merged

Fix 7055 one of with scalar value and string #7173

merged 7 commits into from
Aug 8, 2024

Conversation

mmyyrroonn
Copy link
Contributor

Description

Fix #7055

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

@luu-alex
Copy link
Contributor

Thanks for submitting the PR! I have some feedback, but overall it looks good :) thanks alot. Also update the changelog.
Add this under unreleased as a fix.

@mmyyrroonn
Copy link
Contributor Author

Thanks for submitting the PR! I have some feedback, but overall it looks good :) thanks alot. Also update the changelog. Add this under unreleased as a fix.

Sure. Let me add more tests and update the README

@mmyyrroonn mmyyrroonn force-pushed the fix-7055-oneOf-with-scalar-value-and-string branch from 4b59c10 to 40ddd19 Compare August 6, 2024 07:59
@mmyyrroonn mmyyrroonn marked this pull request as ready for review August 6, 2024 08:31
@mmyyrroonn mmyyrroonn requested a review from luu-alex August 6, 2024 08:31
@luu-alex
Copy link
Contributor

luu-alex commented Aug 6, 2024

Thank you @mmyyrroonn for the PR. We will get this in by next release :)

@luu-alex luu-alex merged commit 0db2b18 into web3:4.x Aug 8, 2024
16 of 18 checks passed
@aashutoshrathi aashutoshrathi mentioned this pull request Sep 13, 2024
Open
This was referenced Sep 13, 2024
Open
Open
@swirlds-automation swirlds-automation mentioned this pull request Sep 17, 2024
Merged
@AKJUS AKJUS mentioned this pull request Sep 18, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Sep 22, 2024
Open
@HaLaGu1L HaLaGu1L mentioned this pull request Nov 3, 2024
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@avkos avkos avkos approved these changes

@luu-alex luu-alex luu-alex approved these changes

@jdevcs jdevcs Awaiting requested review from jdevcs jdevcs is a code owner

@Muhammad-Altabba Muhammad-Altabba Awaiting requested review from Muhammad-Altabba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Format schema with oneOf doesn't work correctly
3 participants
@mmyyrroonn @luu-alex @avkos