Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Commit acdb0c7

Browse files
authored
Fixes for Minor Typographical Errors are Not Accepted (#7406)
Replaces #7405
1 parent 926044b commit acdb0c7

File tree

4 files changed

+38
-28
lines changed

4 files changed

+38
-28
lines changed

.github/CONTRIBUTING.md

+15-6
Original file line numberDiff line numberDiff line change
@@ -8,35 +8,45 @@ If you face any issues while contributing or want any type of support, we encour
88

99
## Prerequisites
1010

11-
- [NodeJS](https://nodejs.org/) (LTS)
12-
- [Yarn](https://yarnpkg.com/)
11+
- [NodeJS](https://nodejs.org/) (LTS)
12+
- [Yarn](https://yarnpkg.com/)
1313

1414
## Contributing to the docs
1515

16+
> [!NOTE]
17+
> Contributions that only address relatively minor typographical errors are not accepted. If you believe you have identified an important typographical error that should be addressed, [please open an Issue](https://github.com/web3/web3.js/issues/new?assignees=&labels=Documentation&projects=&template=issue-template.md&title=[Typo]).
18+
1619
1. **Fork the docs:** Start by forking our repository to your GitHub account.
1720

1821
2. **Clone the repo:** Clone the forked repository to your local machine using the following command:
22+
1923
```bash
2024
git clone https://github.com/your-username/web3.js.git
2125
```
26+
2227
3. **Create a Branch:** Create a new branch for your changes with a descriptive name.
23-
**NOTE: The branch name must include the issue number (if there is no issue created for your contribution, please create one).**
28+
**NOTE: The branch name must include the issue number (if there is no issue created for your contribution, please create one).**
29+
2430
```bash
2531
git checkout -b issue-name-1234
2632
```
33+
2734
4. **Navigate to the docs folder:** `cd web3.js/docs/docs`
2835

29-
5. **Install dependencies:**
36+
5. **Install dependencies:**
37+
3038
```bash
3139
yarn
3240
```
41+
3342
6. **Make your changes:**...
3443

3544
7. Check changes in the local environment: Run the command `yarn start` and you'll see a local environment in `localhost:3000` with the documents.
3645

37-
8. **Commit your changes:** `git add .` and `git commit -m 'descriptive msg'`
46+
8. **Commit your changes:** `git add .` and `git commit -m 'descriptive msg'`
3847

3948
9. **Push your changes:**
49+
4050
```bash
4151
git push origin branch-name
4252
```
@@ -96,4 +106,3 @@ Emergency releases are allowed to shorten waiting periods depending on the sever
96106
There is precedent set for this in the 1.2.6 release (see [#3351](https://github.com/ethereum/web3.js/pull/3351)), where the consensus view was to make the smallest change necessary to address the emergency while waiving the `rc` process (meaning many existing additions to master were excluded).
97107

98108
This topic is under further org-wide discussion at [ethereum/js-organization#6](https://github.com/ethereum/js-organization/issues/6).
99-

.github/PULL_REQUEST_TEMPLATE.md

+18-17
Original file line numberDiff line numberDiff line change
@@ -11,23 +11,24 @@ Fixes #(issue)
1111

1212
<!-- Please delete options that are not relevant. -->
1313

14-
- [ ] Bug fix (non-breaking change which fixes an issue)
15-
- [ ] New feature (non-breaking change which adds functionality)
16-
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
14+
- [ ] Bug fix (non-breaking change which fixes an issue)
15+
- [ ] New feature (non-breaking change which adds functionality)
16+
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
17+
- [ ] Documentation (changes that only address relatively minor typographical errors are not accepted)
1718

1819
## Checklist:
1920

20-
- [ ] I have selected the correct base branch.
21-
- [ ] I have performed a self-review of my own code.
22-
- [ ] I have commented my code, particularly in hard-to-understand areas.
23-
- [ ] I have made corresponding changes to the documentation.
24-
- [ ] My changes generate no new warnings.
25-
- [ ] Any dependent changes have been merged and published in downstream modules.
26-
- [ ] I ran `npm run lint` with success and extended the tests and types if necessary.
27-
- [ ] I ran `npm run test:unit` with success.
28-
- [ ] I ran `npm run test:coverage` and my test cases cover all the lines and branches of the added code.
29-
- [ ] I ran `npm run build` and tested `dist/web3.min.js` in a browser.
30-
- [ ] I have tested my code on the live network.
31-
- [ ] I have checked the Deploy Preview and it looks correct.
32-
- [ ] I have updated the `CHANGELOG.md` file in the root folder.
33-
- [ ] I have linked Issue(s) with this PR in "Linked Issues" menu.
21+
- [ ] I have selected the correct base branch.
22+
- [ ] I have performed a self-review of my own code.
23+
- [ ] I have commented my code, particularly in hard-to-understand areas.
24+
- [ ] I have made corresponding changes to the documentation.
25+
- [ ] My changes generate no new warnings.
26+
- [ ] Any dependent changes have been merged and published in downstream modules.
27+
- [ ] I ran `npm run lint` with success and extended the tests and types if necessary.
28+
- [ ] I ran `npm run test:unit` with success.
29+
- [ ] I ran `npm run test:coverage` and my test cases cover all the lines and branches of the added code.
30+
- [ ] I ran `npm run build` and tested `dist/web3.min.js` in a browser.
31+
- [ ] I have tested my code on the live network.
32+
- [ ] I have checked the Deploy Preview and it looks correct.
33+
- [ ] I have updated the `CHANGELOG.md` file in the root folder.
34+
- [ ] I have linked Issue(s) with this PR in "Linked Issues" menu.

packages/web3-core/CHANGELOG.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ Documentation:
123123

124124
### Added
125125

126-
- Web3Subscription constructor accept a Subscription Manager (as an alternative to accepting Request Manager that is now marked marked as deprecated) (#6210)
126+
- Web3Subscription constructor accept a Subscription Manager (as an alternative to accepting Request Manager that is now marked as deprecated) (#6210)
127127

128128
### Changed
129129

@@ -185,7 +185,7 @@ Documentation:
185185

186186
- defaultTransactionType is now type 0x2 instead of 0x0 (#6282)
187187
- Allows formatter to parse large base fee (#6456)
188-
- The package now uses `EventEmitter` from `web3-utils` that works in node envrioment as well as in the browser. (#6398)
188+
- The package now uses `EventEmitter` from `web3-utils` that works in node environment as well as in the browser. (#6398)
189189

190190
### Fixed
191191

@@ -205,7 +205,7 @@ Documentation:
205205

206206
### Changed
207207

208-
- Web3config `contractDataInputFill` has been defaulted to `data`, istead of `input`. (#6622)
208+
- Web3config `contractDataInputFill` has been defaulted to `data`, instead of `input`. (#6622)
209209

210210
## [4.4.0]
211211

@@ -225,7 +225,7 @@ Documentation:
225225

226226
### Added
227227

228-
- Now when existing packages are added in web3, will be avalible for plugins via context. (#7088)
228+
- Now when existing packages are added in web3, will be available for plugins via context. (#7088)
229229

230230
## [4.5.1]
231231

packages/web3-utils/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
This is a sub-package of [web3.js][repo].
1313

14-
`web3-utils` This contains useful utility functions for Dapp developers.
14+
`web3-utils` contains useful utility functions for Dapp developers.
1515

1616
## Installation
1717

0 commit comments

Comments
 (0)